Feature/navigation component #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avigation-component
ahdinosaur
reviewed
Jul 13, 2017
app/components/Navigation.js
Outdated
| constructor (props) { | ||
| super(props) | ||
| this.state = { | ||
| drawerOpen: false |
There was a problem hiding this comment.
i'm a fan of is* boolean props, so isDrawerOpen. helps disambiguate from thinking that this is a function which opens the drawer. what do you think?
app/components/Navigation.js
Outdated
| class Navigation extends React.Component { | ||
| constructor (props) { | ||
| super(props) | ||
| this.state = { |
There was a problem hiding this comment.
i know i mentioned this before, but what do you think about using recompose to handle stateful or lifecycle components? while i did say "functional purity" can be a trap, i am enjoying using recompose so far.
so this would be:
import { connect as connectFela } from 'react-fela'
import { withState, withHandlers } from 'recompose'
import { pipe, not } from 'ramda'
import styles from '../styles/Navigation'
const Navigation = (props) => {
// render...
}
export default pipe(
connectFela(styles),
withState('isDrawerOpen', 'setDrawerOpen', false),
withHandlers({
toggleDrawer: ({ setDrawerOpen }) => () => setDrawerOpen(not)
})
)(Navigation)There was a problem hiding this comment.
yeaaaahhh nice ! i wanted to ask you how to do this actually - will give it a go!
ahdinosaur
reviewed
Jul 13, 2017
app/components/Navigation.js
Outdated
| } | ||
|
|
||
| export default pipe( | ||
| connectFela(styles) | ||
| export default compose( |
There was a problem hiding this comment.
good call on using recompose.compose 👍
ahdinosaur
reviewed
Jul 13, 2017
app/components/Navigation.js
Outdated
| drawerOpen: false | ||
| } | ||
| } | ||
| function Navigation (props) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #95